Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify base64url definition #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clarify base64url definition #270

wants to merge 1 commit into from

Conversation

Sakurann
Copy link
Collaborator

@Sakurann Sakurann commented Sep 26, 2024

resolves #236

Copy link
Member

@c2bo c2bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change - makes it pretty clear imho

2 parts that I think should also be slightly adjusted / wasn't sure about that also reference base64url encoding.

761:

The following is a non-normative example of the payload of the JWT used in the example above before base64url encoding and signing:

--> something like

The following is a non-normative example of the payload of the JWT used in the example above before getting base64url-encoded and signed:

1073 - not sure about this one:

(1) The Verifier produces a nonce value by generating at least 16 fresh, cryptographically random bytes with sufficient entropy, associates it with the session and base64url encodes it.

@jogu jogu added the editorial label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that the vp_token is **URL Safe** Base64 encoded, rather than a Base 64 encoded
4 participants