Introduce new query language (Approach 3) #266

danielfett · 2024-09-18T09:16:20Z

This approach uses ids and a separate definition of valid sets of claims/credentials to return.

~~The draft text has not been adapted yet, let's discuss the JSON examples first!~~

Text is now updated as well, please review.

List of issues to solve in separate PRs:

Introduce transformed claims?
Determine if we need any other format-specific parameters
Define interaction with existing query lang (see co-existence of multiple query languages #211)
Define how requesting presentations with scope works with the new QL.
Define new format for the VP Token
Maybe re-introduce purpose?

Fixes #178
Fixes #249
Fixes #255 (or rather, makes it obsolete)
Fixes #193
Fixes #161 (that was the discussion on the requirements for this new language)
Fixes #157 (mandatory to implement features of the query language)
Fixes #164
Fixes #160
Fixes #148

Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Oliver Terbu <[email protected]> Co-authored-by: Christian Bormann <[email protected]>

This reverts commit 7d71960.

Co-authored-by: Michael B. Jones <[email protected]>

Co-authored-by: Christian Bormann <[email protected]>

Co-authored-by: Timo Glastra <[email protected]>

openid-4-verifiable-presentations-1_0.md

paulbastian

I would prefer having the format specific parameters defined in Appendix B instead of defining mdoc + SD-JWT VC there, but that's not a blocker for me to merge this important piece forward

decentralgabe

I don't see a way to filter on conditional data, has this been excluded intentionally?

For example, requiring that an age field is over 21 is incredibly useful and prevents unnecessary disclosure.

If I have a credential and I'm 20 then I should not need to send the credential (or a subset of its fields) when I could simply determine that I should send nothing.

Without these types of conditionals the query language promotes over-identification.

danielfett · 2024-10-22T18:20:45Z

I don't see a way to filter on conditional data, has this been excluded intentionally?

For example, requiring that an age field is over 21 is incredibly useful and prevents unnecessary disclosure.

If I have a credential and I'm 20 then I should not need to send the credential (or a subset of its fields) when I could simply determine that I should send nothing.

Without these types of conditionals the query language promotes over-identification.

This is not part of this PR, but there's a plan how to do it — we can use the "transformed claims" syntax from "Advanced Syntax for Claims" from the OpenID eKYC working group.

danielfett · 2024-10-22T18:28:02Z

I would prefer having the format specific parameters defined in Appendix B instead of defining mdoc + SD-JWT VC there, but that's not a blocker for me to merge this important piece forward

We can easily move these later with an editorial PR.

Co-authored-by: Paul Bastian <[email protected]>

danielfett · 2024-10-22T18:40:11Z

I think we should define a better name for the query language; somewhat following @decentralgabe's proposal above, I propose Digital Credential Query Language (DCQL, pronounced Dackel).

openid-4-verifiable-presentations-1_0.md

David-Chadwick

minor editorial change requested

David-Chadwick · 2024-10-22T21:21:25Z

openid-4-verifiable-presentations-1_0.md

+  - optionally, any of the other Credential Set Queries.
+
+To satisfy a Credential Set Query, the Wallet MUST return a presentation of a
+Credential or of Credentials that match to one of the `options` inside the


Suggested change

Credential or of Credentials that match to one of the `options` inside the

set of Credentials that match to one of the `options` inside the

bc-pi · 2024-10-22T21:44:43Z

openid-4-verifiable-presentations-1_0.md

+`namespace`:
+: REQUIRED if the Credential Format is based on the mdoc format defined in ISO 18013-5; MUST NOT be present otherwise. 
+The value MUST be a string that specifies the namespace of the data element
+within the mdoc, e.g., `org.iso.18013.5.1`.
+
+`claim_name`:
+: REQUIRED if the Credential Format is based on mdoc format defined in ISO 18013-5; MUST NOT be present otherwise. 
+The value MUST be a string that specifies the data element identifier of the data element within the provided namespace
+in the mdoc, e.g., `first_name`.


I still don't understand why these can't or shouldn't or aren't conveyed with path too i.e. ["org.iso.18013.5.1","first_name"] but I'll not stand in the way of progress for this PR and make a note to myself to ask/complain about it later. Or maybe just forget.

yeah, I still don't really like this special handling for mdocs. Its pain when implementing it too. So I guess same question from me, can everything just be paths?

Please continue the discussion in #293

Sorry, I should have noted #293 here when I created it.

openid-4-verifiable-presentations-1_0.md

bc-pi

"I have some questions, a couple of suggestions ... " but overall approve.

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Brian Campbell <[email protected]>

c2bo

I share some of the questions already raised, but we should start with something and iterate from there. I think this PR provides a good point for that and we can work out some of the details in the coming weeks/months.
Thanks for the patience @danielfett!

c2bo · 2024-10-23T05:55:49Z

openid-4-verifiable-presentations-1_0.md

+
+`values`:
+: OPTIONAL. An array of strings, integers or boolean values that specifies the expected values of the claim.
+If the `values` property is present, the Wallet SHOULD return the claim only if the


Things like "contains" or more advanced functions would (if added) live on this level as well?

yes! Please see the proposal linked in #288

jogu · 2024-10-23T10:32:53Z

Discussed on working group call yesterday - there was unanimous agreement to merge this once Daniel's suggested changes for naming are added (which they have been), and to open issues for all items that still need further discussion. To follow the WG's consensus we will dismiss the 'request for changes' and merge.

This is very much a first version, but well over 200 comments it is very difficult to have productive discussions on this PR, and having focussed issues and PRs will make progress easier and make sure we can track items, get consensus and close them off. For clarity we can (and very likely will) make breaking changes to the query language between now and the spec going final. Nothing is being set in stone by merging this.

It would be a great help to the chairs if people can make sure there are issues open for any unaddressed comments they have made - many thanks to those of you that have already done that! We will try to cover at least some of these issues at the hybrid meeting next week.

Many thanks to Daniel for all his hard work on this, and thanks to everyone that has provided feedback and suggestions that have helped improve the proposal - all the time that has been spent on this is greatly appreciated.

As per #266 (comment)

danielfett and others added 24 commits July 25, 2024 14:03

First draft of new query language

665eda8

Merge branch 'main' into danielfett/vp-query-language

7562b69

Fix compile errors

157e696

Apply suggestions from code review

e4bd784

Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Oliver Terbu <[email protected]> Co-authored-by: Christian Bormann <[email protected]>

Add back accidentally deleted whitespace

bf0ee77

Fix anchor name

7d71960

Revert "Fix anchor name"

50b1721

This reverts commit 7d71960.

Fix anchor name

2005364

Apply suggestions from Mike's code review

ba440ba

Co-authored-by: Michael B. Jones <[email protected]>

Update openid-4-verifiable-presentations-1_0.md

24aa273

Co-authored-by: Christian Bormann <[email protected]>

Merge branch 'main' into danielfett/vp-query-language

8db4ddb

Remove purpose from credential query language proposal

acdfd88

Add missing vp_query definition back into the PR

110714c

Remove another purpose mention

da38019

New format in examples

da854b3

Merge branch 'main' into danielfett/vp-query-language-2

ef77fbf

Update spec text

d21e8e9

Add value matching

1263648

Apply suggestions from code review

df46111

Co-authored-by: Timo Glastra <[email protected]>

Add comments

fc66dd1

New proposal for QL

c2d3f9e

Improve comments

1b0c504

Improve examples

c37d2e3

Merge branch 'main' into danielfett/vp-query-language-3

45490ef

danielfett requested review from paulbastian, TimoGlastra, Sakurann, martijnharing, jogu and David-Chadwick September 18, 2024 09:24

paulbastian reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

paulbastian approved these changes Oct 22, 2024

View reviewed changes

decentralgabe reviewed Oct 22, 2024

View reviewed changes

Apply suggestions from code review

eb353e3

Co-authored-by: Paul Bastian <[email protected]>

bc-pi mentioned this pull request Oct 22, 2024

Rework W3C DC API examples #254

Merged

Rename to DCQL, add purpose to examples

fc06b5b

danielfett mentioned this pull request Oct 22, 2024

Filter on data in DCQL #288

Open

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

David-Chadwick approved these changes Oct 22, 2024

View reviewed changes

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Oct 22, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi approved these changes Oct 22, 2024

View reviewed changes

danielfett commented Oct 23, 2024

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Apply suggestions from Brian's review

5e39e18

Co-authored-by: Brian Campbell <[email protected]>

c2bo approved these changes Oct 23, 2024

View reviewed changes

Address Brian's comments

ff62fcf

jogu merged commit 2eaa550 into main Oct 23, 2024
2 checks passed

bc-pi mentioned this pull request Oct 23, 2024

DCQL: namespace and claim_name vs path #293

Open

danielfett mentioned this pull request Oct 25, 2024

vp_token encoding is not 100% clear #295

Open

sloops77 mentioned this pull request Nov 3, 2024

Support for selecting multiple credentials via a single dcql #298

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce new query language (Approach 3) #266

Introduce new query language (Approach 3) #266

danielfett commented Sep 18, 2024 •

edited

Loading

paulbastian left a comment

decentralgabe left a comment

danielfett commented Oct 22, 2024

danielfett commented Oct 22, 2024

danielfett commented Oct 22, 2024

David-Chadwick left a comment

David-Chadwick Oct 22, 2024

bc-pi Oct 22, 2024

leecam Oct 24, 2024

danielfett Oct 24, 2024

bc-pi Oct 24, 2024

bc-pi left a comment

c2bo left a comment

c2bo Oct 23, 2024

danielfett Oct 23, 2024

jogu commented Oct 23, 2024

	Credential or of Credentials that match to one of the `options` inside the
	set of Credentials that match to one of the `options` inside the

Introduce new query language (Approach 3) #266

Introduce new query language (Approach 3) #266

Conversation

danielfett commented Sep 18, 2024 • edited Loading

paulbastian left a comment

Choose a reason for hiding this comment

decentralgabe left a comment

Choose a reason for hiding this comment

danielfett commented Oct 22, 2024

danielfett commented Oct 22, 2024

danielfett commented Oct 22, 2024

David-Chadwick left a comment

Choose a reason for hiding this comment

David-Chadwick Oct 22, 2024

Choose a reason for hiding this comment

bc-pi Oct 22, 2024

Choose a reason for hiding this comment

leecam Oct 24, 2024

Choose a reason for hiding this comment

danielfett Oct 24, 2024

Choose a reason for hiding this comment

bc-pi Oct 24, 2024

Choose a reason for hiding this comment

bc-pi left a comment

Choose a reason for hiding this comment

c2bo left a comment

Choose a reason for hiding this comment

c2bo Oct 23, 2024

Choose a reason for hiding this comment

danielfett Oct 23, 2024

Choose a reason for hiding this comment

jogu commented Oct 23, 2024

danielfett commented Sep 18, 2024 •

edited

Loading