-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed: change "SIOP" term to "wallet" #146
Conversation
8 approvals. open for more than a week. agreement to merge during WG calls, with a possibility of @paulbastian doing a PR adding examples of KB JWT. * Add annex for SD-JWT VC format * Fix formatting * Updated kb-jwt to include nonce and aud from the request * Clarify nonce and aud claims of kb-jwt as a note * Update presentation request to authorization request Co-authored-by: Brian Campbell <[email protected]> * Introduce unsecured sd-jwt vc payload to help explain how to match requested claims defined in PE * Add example of unsecured payload sd-jwt vc * Remove statement PD input_descriptor vc+sd-jwt format object to be empty * Add sd-jwt and kb-jwt algorithms to the PD example * Editorial: consistent use of IETF SD-JWT VC when mentioning the format * Capitalize Credentials Co-authored-by: Christian Bormann <[email protected]> * Simplify wording Co-authored-by: Christian Bormann <[email protected]> * Remove newlines from end of file * Remove .DS_Store file from credentials folder * Change protection of jwts into signing of jwts Co-authored-by: Kristina <[email protected]> * protection -> signing Co-authored-by: Paul Bastian <[email protected]> * verifier -> Verifier Co-authored-by: Oliver Terbu <[email protected]> * Small fix Co-authored-by: Oliver Terbu <[email protected]> * Apply suggestions from code review Co-authored-by: Oliver Terbu <[email protected]> --------- Co-authored-by: Brian Campbell <[email protected]> Co-authored-by: Christian Bormann <[email protected]> Co-authored-by: Kristina <[email protected]> Co-authored-by: Paul Bastian <[email protected]> Co-authored-by: Oliver Terbu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this based on the discussion on the issue ( #96 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this based on the discussion on #96
editorial. one approval. open for more than a week. not controversial. Co-authored-by: Kristina Yasuda <[email protected]>
editorial. two approvals. open for a week. not controversial.
four approvals. editorial. open for more than a week. non-controvertial. * Add kb-jwt example * Update examples/response/kb_jwt_unsecured.json Co-authored-by: Brian Campbell <[email protected]> --------- Co-authored-by: Brian Campbell <[email protected]>
three approvals. open for more than a week. no objection to merge during the WG call. * Add IETF SD-JWT VC in places where other credential formats are mentioned * Add entry to document history for adding Appendix on SD-JWT VC * Use oxford comma Co-authored-by: Brian Campbell <[email protected]> * Update openid-4-verifiable-presentations-1_0.md Co-authored-by: Kristina <[email protected]> * Add (VCDM) for consistency Co-authored-by: Kristina <[email protected]> * Fix version log Co-authored-by: Joseph Heenan <[email protected]> --------- Co-authored-by: Brian Campbell <[email protected]> Co-authored-by: Kristina <[email protected]> Co-authored-by: Joseph Heenan <[email protected]>
the main is outdated. closing to reopen as a new PR for clarity. |
fixes #96.