-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed: clarify the usage of response uri with response mode direct_post #138
Conversation
Co-authored-by: Jan Vereecken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I had one question and I just want to make sure we are not missing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @peppelinux's proposed change.
I approve this PR Probably, in another PR, we should say something about the value of configuring client_id_scheme differently it turns out that redirect_uri refers to a "direct trust model" therefore, as mentioned in other issues, the client_id_scheme parameter is not related about how to interpret the the client id value but to the trust evaluation mechanism to attest the client identity |
Do we suppose to resolve the issue #33 too using this PR? |
I think for simplicity we should keep that in a separate PR, as this one is hopefully very close to being merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I withdraw my request for changes.
Github didn't remove this for some reason, dismissing as Mike has withdrawn it as per his 15th July comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR
I think we're close on this one - there is one comment from Oliver that needs addressed somehow, and there's some conflicts, but I'm happy to fix the conflicts once we have resolution on Oliver's comment. |
Co-authored-by: Oliver Terbu <[email protected]>
resolves #93.
cc @javereec