Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed: clarify the usage of response uri with response mode direct_post #138

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

Sakurann
Copy link
Collaborator

resolves #93.

cc @javereec

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Vereecken <[email protected]>
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I had one question and I just want to make sure we are not missing anything.

Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @peppelinux's proposed change.

@peppelinux
Copy link
Member

I approve this PR

Probably, in another PR, we should say something about the value of configuring client_id_scheme differently

it turns out that redirect_uri refers to a "direct trust model"

therefore, as mentioned in other issues, the client_id_scheme parameter is not related about how to interpret the the client id value but to the trust evaluation mechanism to attest the client identity

@peppelinux
Copy link
Member

Do we suppose to resolve the issue #33 too using this PR?

@jogu
Copy link
Collaborator

jogu commented Jul 15, 2024

Do we suppose to resolve the issue #33 too using this PR?

I think for simplicity we should keep that in a separate PR, as this one is hopefully very close to being merged now.

Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I withdraw my request for changes.

@jogu jogu dismissed selfissued’s stale review July 16, 2024 08:37

Github didn't remove this for some reason, dismissing as Mike has withdrawn it as per his 15th July comment

Copy link
Contributor

@javereec javereec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR

@jogu
Copy link
Collaborator

jogu commented Jul 25, 2024

I think we're close on this one - there is one comment from Oliver that needs addressed somehow, and there's some conflicts, but I'm happy to fix the conflicts once we have resolution on Oliver's comment.

@Sakurann Sakurann requested a review from awoie July 26, 2024 00:47
@Sakurann Sakurann merged commit f070c6c into main Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirect_uri client_id_scheme: is response_uri optional?
7 participants