Relax language on PE #114
Merged
Relax language on PE #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Chadwick
requested changes
Feb 22, 2024
| @@ -234,7 +234,7 @@ The Authorization Request follows the definition given in [@!RFC6749] taking int | |||
|
|
|||
| The Verifier may send an Authorization Request as Request Object by value or by reference as defined in JWT-Secured Authorization Request (JAR) [@RFC9101]. | |||
|
|
|||
| The Verifier articulates requirements of the Credential(s) that are requested using `presentation_definition` and `presentation_definition_uri` parameters that contain a Presentation Definition JSON object as defined in Section 5 of [@!DIF.PresentationExchange]. Wallet implementations MUST process Presentation Definition JSON object and select candidate Verifiable Credential(s) using the evaluation process described in Section 8 of [@!DIF.PresentationExchange]. | |||
| The Verifier articulates requirements of the Credential(s) that are requested using `presentation_definition` and `presentation_definition_uri` parameters that contain a Presentation Definition JSON object as defined in Section 5 of [@!DIF.PresentationExchange]. Wallet implementations MUST process Presentation Definition JSON object and select candidate Verifiable Credential(s) using the evaluation process described in Section 8 of [@!DIF.PresentationExchange] unless implementing only a credential profile that provides rules on how to evaluate and process [@!DIF.PresentationExchange]. | |||
There was a problem hiding this comment.
MUST should now be relaxed to SHOULD, because the additional text says when the MUST does not apply
There was a problem hiding this comment.
MUST should now be relaxed to SHOULD, because the additional text says when the MUST does not apply
The fact that it's a conditional must doesn't mean it needs to be downgraded to only a recommendation ('should') when the exception doesn't apply. I believe it should stay as a MUST.
There was a problem hiding this comment.
+1 to Joseph. the goal here is to say that when there is no credential profile, use as defined in PE, if there is (like 18013-7), use rules defined there.
There was a problem hiding this comment.
@David-Chadwick does that work for you?
Sakurann
approved these changes
Feb 22, 2024
jogu
approved these changes
Feb 27, 2024
David-Chadwick
approved these changes
Feb 27, 2024
c2bo
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does: