-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove claims
parameter from ISO mdoc and SD-JWT VC Credential Request
#405
Conversation
why removing only for mdoc and not other credential formats? |
it is removed for all credential formats that have selective disclosure themselves, as from discussions that was the only reasoning this parameter was introduced (to enable a kind of selective disclosure for jwt-vc and alike) |
noting that there is no agreement in the issue to remove this parameter. and this needs to be discussed before this can be merged. |
Happy to discuss this in the working group call! |
discussed in the WG, agreement to remove claims/credential_definition parameter for all credential formats from credential requests. but those parameters are kept for authorization details. |
so this PR hopefully entirely resolves #151 because there is an agreement to keep claims in authorization_details and only remove it in credential request |
during the hybrid WG call, agreed to remove all credential format specific claims from credential request. merging this PR since this PR was already ready to fulfill part of that agreement. There will be a follow up PR to complete what was agreed during a WG mtg - ie removing credential format specific claims from w3c vcdm format. |
Partly solves #151
Remove the
claims
parameter from Credential Request for Credential Formats that support selective Disclosure anyway as this: