Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove claims parameter from ISO mdoc and SD-JWT VC Credential Request #405

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

paulbastian
Copy link
Contributor

Partly solves #151

Remove the claimsparameter from Credential Request for Credential Formats that support selective Disclosure anyway as this:

  • is a potential privacy leak to the Credential Issuer
  • hinders interoperability when users have a Credential with subset of claims in their wallet and other Verifiers want other claims (which will be unexplainable to the user)
  • this has been an interop issues in LSP hackathon as particpants interpreted this differently

@Sakurann
Copy link
Collaborator

why removing only for mdoc and not other credential formats?

@paulbastian
Copy link
Contributor Author

why removing only for mdoc and not other credential formats?

it is removed for all credential formats that have selective disclosure themselves, as from discussions that was the only reasoning this parameter was introduced (to enable a kind of selective disclosure for jwt-vc and alike)

@Sakurann
Copy link
Collaborator

noting that there is no agreement in the issue to remove this parameter. and this needs to be discussed before this can be merged.

@paulbastian
Copy link
Contributor Author

Happy to discuss this in the working group call!

@Sakurann
Copy link
Collaborator

discussed in the WG, agreement to remove claims/credential_definition parameter for all credential formats from credential requests. but those parameters are kept for authorization details.

@Sakurann
Copy link
Collaborator

so this PR hopefully entirely resolves #151 because there is an agreement to keep claims in authorization_details and only remove it in credential request

@Sakurann Sakurann merged commit a176546 into main Nov 1, 2024
2 checks passed
@Sakurann
Copy link
Collaborator

Sakurann commented Nov 1, 2024

during the hybrid WG call, agreed to remove all credential format specific claims from credential request. merging this PR since this PR was already ready to fulfill part of that agreement. There will be a follow up PR to complete what was agreed during a WG mtg - ie removing credential format specific claims from w3c vcdm format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants