Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload draft of specification process for review #643

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

DBees
Copy link
Contributor

@DBees DBees commented Jan 5, 2024

No description provided.

### Copyright
The following opyright text is included:

"Copyright © YEAR OF PUBLICATION OpenHW Group. You may use, copy, modify, and distribute this work under the terms of the License, subject to the conditions specified in the License."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright doesnt start with the publication, but with the development.

Copy link
Contributor

@christian-herber-nxp christian-herber-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small points added as single comments.
Further, for CV-X-IF we will very likely be facing a situation where parts of the specification go into review (and may even be published), and other parts will remain draft. Is there a way to handle this?

@DBees
Copy link
Contributor Author

DBees commented Jan 8, 2024

Small points added as single comments. Further, for CV-X-IF we will very likely be facing a situation where parts of the specification go into review (and may even be published), and other parts will remain draft. Is there a way to handle this?

@christian-herber-nxp can you break this into a ratified part, then a separate document which is an extension? Once the extension is ratified we can up-issue the ratified part to include the extension.

@DBees
Copy link
Contributor Author

DBees commented Jan 10, 2024

@christian-herber-nxp @MikeOpenHWGroup new version uploaded

Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry that I have not understood how to use this document. I guess more introductory/process text could help.

process/OpenHW-Specification-Process.md Outdated Show resolved Hide resolved
@@ -0,0 +1,170 @@
# OpenHW Process Document: Specification Process, States and Format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No process is complete without templates and tools. Recommend to provide a template github project from which to start. I would also question if the Specification Process shouldn't just use its own process, and thus its own template. In this case, you should move from MD to RST

DBees and others added 2 commits January 15, 2024 16:52
…ation normally used in Open HW open-source projects
Detailed some abbreviations.
Used our long name "OpenHW Group" in an "official" document
Commons -> Creative Commons 
Several typos
Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the new introduction.
I have performed some minor fixes.

@DBees
Copy link
Contributor Author

DBees commented Jan 19, 2024

@jquevremont thanks for the review and corrections

@DBees
Copy link
Contributor Author

DBees commented Jan 23, 2024

@jeremybennett we'll merge this unless you have comments?

@christian-herber-nxp
Copy link
Contributor

@DBees please mark review items as resolved if you updated the text. that gives an overview if everything has been resolved

Merging Jerome's changes with additional typos and spelling corrections
Copy link
Contributor

@christian-herber-nxp christian-herber-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are parts of the specification process which are not practically implementable with the given templates. The current feedback loop doesn't seem to do a good job in concluding this. The specification process has been written top down, but must be bottom up where technical limitations are in place. For CV-X-IF, I will follow the process where possible, and otherwise try to act in the spirit of this process.
CV-X-IF specification can be worked into a documentation template. Without showing a working template, the process is not complete.

@DBees
Copy link
Contributor Author

DBees commented Jan 30, 2024

@christian-herber-nxp yes, already noted that a template will be added to accompany the process document. Yes, please flag things (such as the footer in PDF) that present particular issues and we'll figure it out.
Duncan

### Specification Revision Numbers

OpenHW Group Specifications shall use semantic versioning https://semver.org/ with the Revision in the form X.Y.Z.
The Revision number is combined with the Specification State (below), for example "1.0.0 - Released" to indicate both the Revision number and State.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not always possible. Better to have postfixes (see semver.org) like -rc.1, -dev etc.


Prior to release a table of draft revisions should be included, which can include description of content in each draft

Upon release, the Revision History should list only released specification Revisions. That is, intermediate revisions used during development and review don't need to be listed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revision history is generated from the releases on github. There is no control over which versions should be listed.

Prior to release a table of draft revisions should be included, which can include description of content in each draft

Upon release, the Revision History should list only released specification Revisions. That is, intermediate revisions used during development and review don't need to be listed.
The table should include Revision, State, Date, and Description. The Description should include a high level description of the content.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, it is what it is. See any document for what to expect

The following is an example of an appropriate license statement:

"
Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX identifier should be given, along with the recommended text from spdx.org for the given license

### Copyright
The following copyright text is included:

"Copyright © YEAR OF PUBLICATION OpenHW Group. You may use, copy, modify, and distribute this work under the terms of the License, subject to the conditions specified in the License."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second sentence here should be part of the license text, not added to a copyright statement

In cases where the specification is rendered in PDF format, a footer should be included on each page, including "OpenHW Group Specification: Title : VX.Y.Z : State", and "Copyright © YEAR OF PUBLICATION OpenHW Group"



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing section: Filename requirementes (especially for pdf publication) - template: OpenHW_Group_Specification_Core-V_eXtension_interface_(CV-X-IF)v1.0.0, i.e. OpenHW_Group_Specification{title_with_underscores}_vX.Y.Z

@DBees
Copy link
Contributor Author

DBees commented Feb 22, 2024

@christian-herber-nxp please review latest in which I changed Specification State to -postfix at your suggestion. Please let me know if the details seem good to you. That would imply that the final version of the spec is published with vx.y.z-rel1 for instance.

- “In Development". The version postfix is -devW, for example -dev1, -dev2
- "In Review" (optional). The version postfix is -reviewW, for example -review1, -review2
- "Release Candidate". The version postfix is -rcW, for example -rc1, -rc2
- "Released". The version postfix is -relW, for example -re11, -rel2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A released version does not have a post-fix

- "OpenHW Group Specification - Released"
- “In Development". The version postfix is -devW, for example -dev1, -dev2
- "In Review" (optional). The version postfix is -reviewW, for example -review1, -review2
- "Release Candidate". The version postfix is -rcW, for example -rc1, -rc2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -rc postfix is separated from its rc version with a dot

- "OpenHW Group Specification - Release Candidate"
- "OpenHW Group Specification - Released"
- “In Development". The version postfix is -devW, for example -dev1, -dev2
- "In Review" (optional). The version postfix is -reviewW, for example -review1, -review2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev and review do not need version numbers beyond the normal version. this is just a special case for release candidates, as they might need to differentiate multiple versions starting with e.g. 1.0.0.
For development versions etc., the main version number would just increment between versions

@@ -231,7 +249,7 @@ The following copyright text is included:

### Footer

In cases where the specification is rendered in PDF format, a footer should be included, if practical in the documentation template used, on each page, including "OpenHW Group Specification: Title : VX.Y.Z : State", and "Copyright © YEAR OF PUBLICATION OpenHW Group"
In cases where the specification is rendered in PDF format, a footer should be included, if practical in the documentation template used, on each page, including "OpenHW Group Specification: Title : VX.Y.Z-postfix", and "Copyright © YEAR OF PUBLICATION OpenHW Group"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V is still capital here

Copy link
Contributor

@christian-herber-nxp christian-herber-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several instances now where due to the changes, the CV-X-IF specification is no longer aligned to the specification process. I would have hoped we align the process to the spec, especially as I aligned this to the process where possible. You will check to work with the conf.py I created and the corresponding template to work that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants