Parametrization step 1 #1896
Merged
Parametrization step 1 #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build_config function is in a new package so that it will be able to
take values from other packages without circular dependency issues.
(Temporary solution to ease implementation)
The value is built by declaring a value then assigning its fields
because Vivado does not support return '{ ... };
It would be better if we could take CVA6Cfg as an argument but it is not accessible everywhere the function is called.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
✔️ successful run, report available here. |
AngelaGonzalezMarino
pushed a commit
to planvtech/cva6
that referenced
this pull request
Mar 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the configuration structure so that the user configuration does not contain dummy values.
This is the first step for #1451
It partially replaces PR #1704
See also the announcement on Mattermost