Add CORE-V headers #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add header files for all CORE-V extensions that have C builtin functions. The definitions of existing builtin functions are also adjusted accordingly.
PaoloS02
force-pushed
the
add-headers
branch
from
4341174
to
e1a8af0
Compare
|
|
||
| #if defined(__riscv_xcvalu) | ||
|
|
||
| #define __DEFAULT_FN_ATTRS __attribute__((__always_inline__, __nodebug__)) |
There was a problem hiding this comment.
This isn't a special symbol, so __DEFAULT_FN_ATTRS does also need to be added to each declaration rather than just defined here.
There was a problem hiding this comment.
Each definition should also be static inline (or, as appears to be the case for other targets' definitions, static __inline__)
PaoloS02
force-pushed
the
add-headers
branch
2 times, most recently
from
768675b
to
e0bf48a
Compare
…ons. This patch changes the C API headers that were added for the CORE-V ISA extensions so that they follow the standard described for RISC-V here: https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md#intrinsic-functions The C API headers must provide a uniform interface for instrinsic functions that is compatible with any compiler that supports them. In the wrapper of a C API intrinsic function definition any compiler can implement the functionality differently, whether it is with an existing instrinsic function, or with inline assembly etc... The user code that adds a C API RISC-V header is agnostic to the implementation and is then compatible with any compiler that has the header. The RISC-V intrinsic functions have - the common prefix '__riscv_' to avoid name collision with other targets. - a vendor specific prefix if they belong to a vendor specific extension. - the name of the function. - the type of the function: this is typically used to distinguish different versions of the same intrinsic function that differ only for the type of one or more operands. Another convention is to use the type 'long' instead of integer types like int32_t or uint32_t as the type 'long' will be set to the current XLEN. According to these conventions the CORE-V intrinsic functions are now redefined like: long __riscv_cv_name_type(long op1, long op2) { return __builtin_riscv_cv_name_type(op1, op2); }
…t arguments. This patch adds macros in the C API header files instead of wrapped calls for those intrinsics which use const arguments. This change affects the intrinsics for: SIMD: - add_h - sub_h - cplxmul_r - cplxmul_i - subrotmj - shuffle_xhi - extract[u]_[h/b] - insert_[h/b] Bitmanip: - bitrev It also changes the type of the immediate argument of extract and shuffle.sci to const in the clang intrinsics definitions.
This is done to separate the tests for the internal implementation of the CORE-V intrinsics from the tests for C API interfaces of the same.
|
I see some testcases failed, |
This is done to avoid multiple defines in the link step if the inlining fails.
8 tasks
|
Implemented in new patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reviewed version of the pull request #78