Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed signedness of simd shuffle and simd avgu #87

Closed

Conversation

adeel10x
Copy link
Contributor

@adeel10x adeel10x commented Nov 7, 2023

The 6-bit immediate operand of cv.shuffle.sci.b, cv.avgu.sci.b, and cv.avgu.sci.h was changed from signed to unsigned, to make implementation consistent with the spec.

@Tameem-10xE
Copy link

Tameem-10xE commented Nov 10, 2023

All tests related to Shuffle SIMD and AVG will pass,
image

@ChunyuLiao
Copy link
Contributor

@adeel10x
Copy link
Contributor Author

@Tameem-10xE has updated the repo. Tests can be run now.

@adeel10x
Copy link
Contributor Author

adeel10x commented Dec 6, 2023

These mac-OS tests are failing for multiple Pull Requests.
image

@PaoloS02
Copy link
Contributor

The changes for avgu were already included with a back ported commit. The fix for the shuffle instruction has been merged with #100 . This can now be closed.

@PaoloS02 PaoloS02 closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants