Alu builtins #75
Merged
Alu builtins #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realqhc
force-pushed
the
alu-builtins
branch
2 times, most recently
from
bd26d0b
to
e9c1320
Compare
ChunyuLiao
reviewed
Sep 1, 2023
realqhc
force-pushed
the
alu-builtins
branch
from
e9c1320
to
ab34ebd
Compare
realqhc
force-pushed
the
alu-builtins
branch
from
ab34ebd
to
f37d180
Compare
|
@jeremybennett @PaoloS02 can we get this commit merged soon? |
PaoloS02
reviewed
Oct 11, 2023
PaoloS02
reviewed
Oct 11, 2023
|
I'm good to merge this as soon as we clarify the indentation matter and the conflicts are solved. One conflict is caused only by the addition of the alu and mac builtins at the "same time". They just need to be both kept. For the second conflict I left a comment. |
Implement XcvAlu Clang Builtins Spec: https://github.com/openhwgroup/core-v-sw/blob/master/specifications/corev-builtin-spec.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtins have been implemented, and it would be great if someone could explain a bit about what error messages are required for some of the builtins in xcvalu extension.