Use target independent builtins #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endent __builtin_rotateright32. Consequently, the definitions of __builtin_riscv_cv_bitmanip_ror and the intrinsic int_riscv_cv_bitmanip_ror were removed, and relevant tests in clang and llvm were updated.
…or. In previous patch, Pat class was used directly
adeel10x
commented
Jan 17, 2024
| } else { | ||
| setOperationAction({ISD::ROTL, ISD::ROTR}, XLenVT, Expand); | ||
|
|
||
| if (!Subtarget.hasExtXcvbitmanip()) { |
There was a problem hiding this comment.
@PaoloS02 This is something you might want to have a look at.
I have edited this code because RISCV Base ISA doesn't have a rotate right instruction and thus during legalization, it expands the ROTR operation into a combination of other supported operations (srl, neg, sll ,or).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for the merge because I haven't covered all possible corev bitmanip builtins yet. For now, only the __builtin_riscv_cv_bitmanip_ror has been replaced with the target independent __builtin_rotateright32.
I am creating a PR so that concerned developers can review the code that has been pushed so far and provide their valuable feedback.