fix: add alternative block device path #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: René Kuhn <[email protected]>
|
Thanks! Looks excellent 👍 |
jgraichen
reviewed
Dec 12, 2024
|
|
||
| if err != nil { | ||
| logger.WithError(err).Error("Expected block device not found") | ||
| return nil, fmt.Errorf("Block device not found: %s", dev) | ||
| logger.WithError(err).Error("Block device not found") |
There was a problem hiding this comment.
Maybe as a later change: Do we want to list which devices were checked here? So that user getting this error message knows what to look for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for alternative block device paths. Currently, the driver only searches for virtio block devices which causes the mounting to fail if a different path is used. With this patch, support for scsi devices is added and additional path formats can be added easily if required in the future.