Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velbus] Add VMB4LEDPWM-20 OnOff command support #18287

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Conversation

Rosen01
Copy link
Contributor

@Rosen01 Rosen01 commented Feb 18, 2025

New functionality :

Signed-off-by: Daniel Rosengarten [email protected]

Rosen01 and others added 4 commits February 9, 2025 23:02
Module VMBPIR-20 is missing in the readme.

Signed-off-by: Daniel Rosengarten <[email protected]>
New functionality :
- Add OnOff command type on Brightness channels for VMB4LEDPWM-20

Signed-off-by: Daniel Rosengarten <[email protected]>
@Rosen01 Rosen01 requested a review from cedricboon as a code owner February 18, 2025 21:45
Sending an ON command will switch the dimmer to the value stored when last turning the dimmer off.

Signed-off-by: Daniel Rosengarten <[email protected]>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel changed the title [velbus] VMB4LEDPWM-20 OnOff command support [velbus] Add VMB4LEDPWM-20 OnOff command support Feb 19, 2025
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Feb 19, 2025
@lsiepel lsiepel added this to the 5.0 milestone Feb 19, 2025
@lsiepel lsiepel merged commit 0ccaa33 into openhab:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Velbus] VMB4LEDPWM-20 ON and OFF commands not responding
2 participants