Convert i18n references in addon.xml to actual text #18139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
requested review from
gs4711,
andrewfg,
a team,
markus7017,
clinique,
mherwege,
stefan-hoehn and
BjoernLange
as code owners
jimtng
force-pushed
the
addon-xml-name-desc
branch
from
56382e9 to
d5ee96f
Compare
The corresponding ids in the properties files are converted to the standard naming so they can be automatically inferred. Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
addon-xml-name-desc
branch
from
d5ee96f to
462b119
Compare
|
Don't you have to recreate the properties files (and remove the old keys)? EDIT: sorry, I see that's done. |
lsiepel
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding ids in the properties files are converted to the standard naming so they can be automatically inferred.
See the discussion #14310 (comment)
TL;DR: This change here should not affect the appearance of the add-ons as they're viewed in mainUI. By using actual text, the
runtime/etc/addons.xmlwhich is built by combining all the addon.xml files, will contain name/description that can be used in MainUI search / display.