[luxtronikheatpump] Adjust previously unknown channels with new information #18133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Please remove changes to this file as this file is maintained trough crowdin
Comment on lines
30
to
31
| <type>Number:Temperature</type> | ||
| <label>Temperature Vapourisation</label> |
There was a problem hiding this comment.
A bit of a nit:
Explicilty adding this type and label should have no effect. If they are not provided here, the label and type from the channel type are used. (applies to all)
lsiepel
added
the
enhancement
…mation Signed-off-by: Stefan Giehl <[email protected]>
Signed-off-by: Stefan Giehl <[email protected]>
Signed-off-by: Stefan Giehl <[email protected]>
sgiehl
force-pushed
the
luxtronik_channels
branch
from
480a09d to
0b64ee5
Compare
|
Thanks @lsiepel for the review. I've applied the requested changes. Let me know if you think anything else should be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The luxtronikheatpump binding contains a couple of channels, where the meaning is not yet known.
#17043 shed some light on a couple of such channels.
This PRs aims to update/rename such channels so have a proper id and label.
Note: I'm unfamilar with how channel changes should be handled. Hope the proposed changes matches the requirements. If not, let me know what to change.
Also I'm unfortunatelly not able to test the changes properly as my own heatpump still runs a software version that does not provide such channels at all. But I'm able to say that the binding at least still works as expected on heatpumps not providing such channels.