[basicprofiles] Convert to relative unit in State Filter's Delta check #18127
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/state-filter-range-filter-profile/158025/58 |
jimtng
force-pushed
the
statefilter-delta-relativeunit
branch
from
470b991 to
3c248fa
Compare
jimtng
changed the title
|
I'll address that in another PR once the current PR backlog to StateFilter has been merged, just to avoid having to deal with merge conflicts. |
andrewfg
requested changes
Jan 23, 2025
.../test/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfileTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfileTest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java
Show resolved
Hide resolved
andrewfg
added
the
enhancement
jimtng
force-pushed
the
statefilter-delta-relativeunit
branch
from
3c248fa to
458caeb
Compare
|
rebased |
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
statefilter-delta-relativeunit
branch
from
458caeb to
ea3dc22
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
statefilter-delta-relativeunit
branch
from
ea3dc22 to
db1e876
Compare
|
rebased to resolve merge conflicts |
|
Is this classed as "enhancement" or "bug"? Ideally this should be backported so people can use it in 4.3 |
andrewfg
added
bug
lsiepel
pushed a commit
that referenced
this pull request
Feb 2, 2025
#18127) * [basicprofiles] Convert to relative unit in State Filter's Delta check Signed-off-by: Jimmy Tanagra <[email protected]>
lsiepel
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in https://community.openhab.org/t/state-filter-range-filter-profile/158025/51