New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Layer groups removed when no layers left in them #97

Merged

suricactus merged 1 commit into master from QF-4520-layer_groups_not_removed_when_no_layers_left

Nov 16, 2024

Member

SeqLaz commented Nov 14, 2024 •

edited

Loading

Removing Layer groups removed when no layers left in them

Test project:

crop_monitoring_000.zip

Implemented on QFieldSync plugin on the PR opengisch/qfieldsync#623

Fix opengisch/qfieldsync#587

SeqLaz requested a review from suricactus

November 14, 2024 22:24

suricactus reviewed

View reviewed changes

libqfieldsync/offline_converter.py Outdated Show resolved Hide resolved

suricactus reviewed

View reviewed changes

libqfieldsync/offline_converter.py Outdated Show resolved Hide resolved

suricactus reviewed

View reviewed changes

libqfieldsync/offline_converter.py Outdated Show resolved Hide resolved

suricactus requested changes

View reviewed changes

Collaborator

suricactus left a comment

Good work! A few small changes and it is ready to go!

Don't forget to open QFieldSync PR with the new libqfieldsync commit sha.

Also make a reference to the fixed issue on QFieldSync here and on the QFieldSync PR.

And don't forget to make cross reference between the two PRs.

suricactus reviewed

View reviewed changes

libqfieldsync/offline_converter.py Outdated Show resolved Hide resolved

SeqLaz force-pushed the QF-4520-layer_groups_not_removed_when_no_layers_left branch from 59b0820 to a250005 Compare

November 15, 2024 12:56

Member Author

SeqLaz commented Nov 15, 2024

Hey @suricactus I addressed the suggestions!.... Also for tests I added the project sample in the descriptions of the PR

suricactus reviewed

View reviewed changes

libqfieldsync/offline_converter.py Outdated Show resolved Hide resolved

suricactus approved these changes

View reviewed changes

Collaborator

suricactus left a comment

One last empty line :)

Please squash into a single commit and we are ready to go!

Member Author

SeqLaz commented Nov 15, 2024

One last empty line :)

Please squash into a single commit and we are ready to go!

Great!... Apologize my bad! :)


          Removing Layer groups removed when no layers left in them

eb0ebd8

SeqLaz force-pushed the QF-4520-layer_groups_not_removed_when_no_layers_left branch from a250005 to eb0ebd8 Compare

November 15, 2024 17:09

Member Author

SeqLaz commented Nov 15, 2024

Hey @suricactus I think now is ready to go!

suricactus approved these changes

View reviewed changes

Collaborator

suricactus left a comment

Great! Don't forget to open a PR on QFieldSync with the new libqfieldsync version, cross reference this PR to the one on QFieldSync and vice versa, and put in both "fixes <LINK_TO_GITHUB_ISSUE>". Ideally this should be done when you open the PR, not just before closing :) .

SeqLaz mentioned this pull request

Adding dependency for layer groups not removed when no layers left opengisch/qfieldsync#623

Open

suricactus merged commit fa79d3c into master

7 checks passed

suricactus deleted the QF-4520-layer_groups_not_removed_when_no_layers_left branch

November 16, 2024 19:16

suricactus added a commit to opengisch/qfieldsync that referenced this pull request


          Update requirements.txt to use the latest libqfieldsync

984373a

opengisch/libqfieldsync#96
opengisch/libqfieldsync#97

suricactus mentioned this pull request

Update requirements.txt to use the latest libqfieldsync opengisch/qfieldsync#625

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet