Fix exporting of geometry-less vector layers when offlining using area of interest #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
reviewed
Oct 30, 2023
| layer.selectByIds([FID_NULL]) | ||
| else: | ||
| # insure that geometry-less layers do not have selected features that would interfere with the process | ||
| layer.removeSelection() |
There was a problem hiding this comment.
I would have expected a select all, does this work?
There was a problem hiding this comment.
@m-kuhn , it works, the logic is in QgsOfflineEditing, and it only extracts selected features when 1 or more is selected, see: https://github.com/qgis/QGIS/blob/master/src/core/qgsofflineediting.cpp#L788C5-L793
m-kuhn
approved these changes
Oct 30, 2023
Merged
|
is this fix icoporated in the latest version? (3.1.9 borneo?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opengisch/QField#4697