-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use trial period on regular plan instead of trial plan #1122
base: master
Are you sure you want to change the base?
[WIP] Use trial period on regular plan instead of trial plan #1122
Conversation
"regular_plan__link", | ||
"trial_plan__link", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to add the admin methods for these two, similar to account__link
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approach is for the list_display
to show only the active plan. Since we already have the property plan
in the model we can get only the active once. The reasons behind this approach is that it saves space, makes UI cleaner and still allows admins to differentiate trial status via the is_trialing
column. If admin wants to see both the regular and trial plans separately, we could add filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's discuss it tomorrow. I thought if a column does not exist, as in our case trial_plan__link
column does not exist, we need to write a get_trial_plan__link
method, but I guess I am wrong.
Current Approach
Currently, we create two separate subscriptions:
Problems with this approach:
New Approach
trial_plan
,a regular plan
and a default number oftrial days
.