Add S3 config for QFC on AWS hosts #1118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faebebin
force-pushed
the
s3-config-for-aws
branch
from
bb0b60c to
8331a82
Compare
faebebin
force-pushed
the
s3-config-for-aws
branch
3 times, most recently
from
477f5fc to
ec2f531
Compare
faebebin
force-pushed
the
s3-config-for-aws
branch
from
ec2f531 to
9d74dfe
Compare
|
@faebebin allowed myself to switch the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: rebase and resolve conflicts
When hosted on AWS botocore automatically uses the IAM auth and env settings for S3, therefore no further env/settings need to be defined and passed to boto3 s3.