Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-axes to v7.0.1 and django-allauth to 65.3.1 #1103

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

gounux
Copy link
Member

@gounux gounux commented Jan 8, 2025

This PR bumps the dependency to its newest version.

axes's changelog: https://github.com/jazzband/django-axes/blob/master/CHANGES.rst#701-2024-12-02

Notable breaking changes: https://django-axes.readthedocs.io/en/latest/2_installation.html#version-7-breaking-changes-and-upgrading-from-django-axes-version-6

To be tested :

  • try 6 unsuccessful logins with a correct username and a fake password -> custom QFC lockout page should appear, displaying username :

image

  • try 6 unsuccessful logins with previous user's email address and a fake password -> custom QFC lockout page should appear, displaying email address:

image

  • delete the access attempts in the admin page (or wait for 30min), then:
    • try again a login with username and correct password -> should be logged in
    • log out and try again a login with email address and correct password -> should be logged in

@duke-nyuki
Copy link
Collaborator

Task linked: QF-4848 Bump django-axes to 6.0.0+

@gounux gounux marked this pull request as ready for review January 9, 2025 08:09
@gounux gounux requested a review from suricactus January 9, 2025 08:09
@gounux gounux mentioned this pull request Jan 12, 2025
4 tasks
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and force push all in a single commit and we are ready to merge then.

@gounux
Copy link
Member Author

gounux commented Jan 14, 2025

Please squash and force push all in a single commit and we are ready to merge then.

From other PR (#1084) which has been merged into this one :

ideally be one per dependency with very strict commits and messages related to tme, so they can be easily reverted when needed

Wouldn't be willing to to mess things up here, and would like to ask you how to proceed with this one to get only a single commit per dependency bump, assuming squashing all of them on this branch would regroup both bumps when merged on master later

@suricactus suricactus changed the title Bump django-axes to v7.0.1 Bump django-axes to v7.0.1 and django-allauth to 65.3.1 Jan 14, 2025
@gounux gounux merged commit 41543e6 into master Jan 14, 2025
13 checks passed
@gounux gounux deleted the QF-4848-bump-axes-to-v6 branch January 14, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants