Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add token filter and action #1058

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Add token filter and action #1058

merged 5 commits into from
Nov 13, 2024

Conversation

gounux
Copy link
Contributor

@gounux gounux commented Nov 12, 2024

  • add a token filter based on client type (e.g. QField, QFieldSync, Browser...)
  • add a custom action to disable a token by setting it's expiration date to now

suricactus
suricactus approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I had to do some nitpicking by commenting on the comments...

@m-kuhn
Copy link
Member

m-kuhn commented Nov 12, 2024

Thanks for this! 🎉
Would it be possible to add type hints?

suricactus
suricactus approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@suricactus suricactus merged commit 6e7547f into opengisch:master Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gounux @m-kuhn @suricactus