Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crash-prone data-defined label property from sample bees project #5970

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Jan 31, 2025

This label visibility data defined property was causing random crashes:

Screenshot From 2025-01-31 14-47-02

Stacktrace:

libqfield_arm64-v8a
+0x315dd3c
OGRSpatialReference::GetCoordinateEpoch (ogrspatialreference.cpp:13288)
libqfield_arm64-v8a
+0x315dd3c
OSRGetCoordinateEpoch (ogrspatialreference.cpp:13305)
libqfield_arm64-v8a
+0x23fa42c
QgsOgrUtils::OGRSpatialReferenceToCrs (qgsogrutils.cpp:1171)
libqfield_arm64-v8a
+0x1ff4b18
QgsOgrProvider::crs (qgsogrprovider.cpp:3715)
libqfield_arm64-v8a
+0x20561d4
QgsOgrFeatureSource::QgsOgrFeatureSource (qgsogrfeatureiterator.cpp:823)
libqfield_arm64-v8a
+0x1fefdfc
QgsOgrProvider::featureSource (qgsogrprovider.cpp:551)
libqfield_arm64-v8a
+0x2a78568
QgsVectorLayerFeatureSource::QgsVectorLayerFeatureSource (qgsvectorlayerfeatureiterator.cpp:44)
libqfield_arm64-v8a
+0x2a2fe88
QgsVectorLayer::getFeatures (qgsvectorlayer.cpp:1337)
libqfield_arm64-v8a
+0x233ee14
QgsFeatureSource::materialize (qgsfeaturesource.cpp:168)
libqfield_arm64-v8a
+0x1ea82c4
executeGeomOverlay (qgsexpressionfunction.cpp:7870)
libqfield_arm64-v8a
+0x1e85d04
fcnGeomOverlayNearest (qgsexpressionfunction.cpp:8365)
libqfield_arm64-v8a
+0x1ded114
QgsExpressionFunction::run (qgsexpressionfunction.cpp:120)
libqfield_arm64-v8a
+0x1de5008
QgsExpressionNodeFunction::evalNode (qgsexpressionnodeimpl.cpp:1075)
libqfield_arm64-v8a
+0x1decff0
QgsExpressionFunction::run (qgsexpressionfunction.cpp:109)
libqfield_arm64-v8a
+0x1de5008
QgsExpressionNodeFunction::evalNode (qgsexpressionnodeimpl.cpp:1075)
libqfield_arm64-v8a
+0x1de0ae8
QgsExpressionNodeBinaryOperator::evalNode (qgsexpressionnodeimpl.cpp:207)
libqfield_arm64-v8a
+0x2422ec0
QgsProperty::propertyValue (qgsproperty.cpp:560)
libqfield_arm64-v8a
+0x2422fc8
QgsProperty::value (qgsproperty.cpp:588)
libqfield_arm64-v8a
+0x2423970
QgsProperty::valueAsBool (qgsproperty.cpp:752)
libqfield_arm64-v8a
+0x2424304
QgsAbstractPropertyCollection::valueAsBool (qgspropertycollection.cpp:96)
libqfield_arm64-v8a
+0x2913a3c
QgsAbstractPropertyCollection::valueAsBool<T> (qgspropertycollection.h:316)
libqfield_arm64-v8a
+0x2913a3c
QgsPalLayerSettings::registerFeatureWithDetails (qgspallabeling.cpp:1980)
libqfield_arm64-v8a
+0x29303f4
QgsVectorLayerLabelProvider::registerFeature (qgsvectorlayerlabelprovider.cpp:199)

Both @m-kuhn and myself ran into the crash, and while we should eventually fix the crash upstream for now let's just remove it to make sure our sample project doesn't crash on anyone. Most recently seen while testing tracking optimizations.

@qfield-fairy
Copy link
Collaborator

@nirvn nirvn merged commit f9b893b into master Jan 31, 2025
25 checks passed
@nirvn nirvn deleted the sample_crash_fix branch January 31, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants