Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce auto-push settings coming from the project file #5060

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Feb 28, 2024

This PR ties in with the following qfieldsync improvement: opengisch/qfieldsync#566

QField will now read and respect the auto-push settings defined in a project file, insuring that people managing a 'fleet' of QField users can easily deploy auto push to their users and insure it's turned on.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Feb 28, 2024

src/core/qgismobileapp.h Show resolved Hide resolved
src/qml/QFieldCloudPopup.qml Outdated Show resolved Hide resolved
@nirvn nirvn force-pushed the respect_force_auto_push branch from a5f1e82 to e128ba2 Compare February 29, 2024 02:21
@nirvn
Copy link
Member Author

nirvn commented Feb 29, 2024

@suricactus , review addressed, thanks!

const bool forceAutoPush = mProject->readBoolEntry( QStringLiteral( "qfieldsync" ), QStringLiteral( "forceAutoPush" ), false );
if ( forceAutoPush )
{
qDebug() << "IN!!!";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the qDebug() here?

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did not test myself.

@nirvn nirvn enabled auto-merge (rebase) March 1, 2024 07:06
@nirvn nirvn force-pushed the respect_force_auto_push branch from 81d8ca2 to 48ef709 Compare March 1, 2024 07:09
@nirvn nirvn merged commit dab3629 into master Mar 1, 2024
20 checks passed
@nirvn nirvn deleted the respect_force_auto_push branch March 1, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants