Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Regarding:
I have removed it because in glm there is not a function out of the box to do this. Although we could implement it, look at http://www.opengl-tutorial.org/intermediate-tutorials/tutorial-17-quaternions/ and “RotationBetweenVectors”. In case it is something that we would like to have, i can make a PR for adding this function, that it is pretty useful (I have tested the exact snipper in my own projects).