Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make a lazy loading of gee gdf..close #919. #922

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

dfguerrerom
Copy link
Collaborator

  • Related to don't retrieve the geometries #919.
  • Basically I create a lazy import on the gdf when it is requested using a full GEE AoiModel.
  • I also changed the AoiView method to add both local and ee layers independently.

@dfguerrerom
Copy link
Collaborator Author

Tests fail on test_total_bounds because of the decimals... I have rounded to 4 decimals, maybe we can change the data regression?

E -- 12.44577020563167
E -- 41.90021953934408
E -- 12.457671530175347
E -- 41.90667181034749

E +- 12.445770205631668
E +- 41.90021953934405
E +- 12.445770205631668
E +- 41.90667181034752

@dfguerrerom
Copy link
Collaborator Author

@12rambau the other tests fail because of the issue with your planet key

@dfguerrerom dfguerrerom marked this pull request as ready for review May 25, 2024 07:26
- set gdf when vector or geojson is set in method.
- don't evaluate gdf in conditions to avoid request when using gee.
@12rambau
Copy link
Member

12rambau commented Jun 3, 2024

find with me.

I really like the smooth implementation with a property.
Let's discard the test from planet for now I'll try to solve my key issues later.

@dfguerrerom dfguerrerom merged commit 3a21961 into main Jun 3, 2024
4 of 9 checks passed
@dfguerrerom dfguerrerom deleted the gee_aoi_model branch June 3, 2024 12:37
@dfguerrerom dfguerrerom restored the gee_aoi_model branch June 17, 2024 08:24
@dfguerrerom dfguerrerom deleted the gee_aoi_model branch August 6, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants