Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make theme change interactive #913

Merged
merged 11 commits into from
May 10, 2024
Merged

feat: make theme change interactive #913

merged 11 commits into from
May 10, 2024

Conversation

dfguerrerom
Copy link
Collaborator

@dfguerrerom dfguerrerom commented May 3, 2024

This PR does the following:

  • change default dark and light theme colors
  • live theme colors change when theme button is clicked
  • add new 'reactive' colors to the theme
  • change the basemap tile to its light/dark variant if they are the default carto basemaps
  • automatically update colors on disclaimers using the logic already set
  • do some small test corrections

See the result:

screen-capture.webm

@12rambau, the video doesn't show the transition so well but I think it is because of the number of frames that my recording tool use.

I know the test will fall because of the gee issue, but that PR stills on hold.

@dfguerrerom dfguerrerom marked this pull request as ready for review May 4, 2024 15:34
@12rambau
Copy link
Member

I love it, checked the code and found nothing to complain about. This feature is so much better than the previous implementation.

@dfguerrerom dfguerrerom merged commit 0b0af7e into main May 10, 2024
4 of 9 checks passed
@dfguerrerom dfguerrerom deleted the live_theme_change branch May 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants