4002 - TablePaginated: Filter by User Role + Admin users 'Role' - Multiselect UI #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minotogna
reviewed
Oct 21, 2024
src/client/components/Inputs/Select/Indicators/MultiValue/MultiValue.tsx
Outdated
Show resolved
Hide resolved
src/client/components/TablePaginated/Filters/MultiSelect/MultiSelect.scss
Outdated
Show resolved
Hide resolved
src/client/components/TablePaginated/Filters/MultiSelect/hooks/useTooltipContent.ts
Outdated
Show resolved
Hide resolved
src/client/components/TablePaginated/Filters/MultiSelect/hooks/useTooltipContent.ts
Outdated
Show resolved
Hide resolved
src/client/components/TablePaginated/Filters/MultiSelect/hooks/useTooltipContent.ts
Outdated
Show resolved
Hide resolved
src/client/components/TablePaginated/Filters/MultiSelect/hooks/useTooltipContent.ts
Outdated
Show resolved
Hide resolved
sorja
reviewed
Oct 21, 2024
src/client/components/TablePaginated/Filters/MultiSelect/hooks/useTooltipContent.ts
Outdated
Show resolved
Hide resolved
minotogna
approved these changes
Oct 21, 2024
mergify
bot
merged commit f6ca56a
into
4002-tablepaginated-filter-by-user-role--admin-users-role
5 checks passed
mergify
bot
deleted the
4002-tablepaginated-filter-by-role-ui-multi-select
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
* 4002 - Tablepaginated filter by user role/admin users role - Integration (#4038) * 4002 - Add Filter multi select type * 4002 - Add draft multi select to Users table * 2661 - Display all columns * 4002 - TablePaginated: Filter by User Role + Admin users 'Role' - Multiselect UI (#4049) * 4002 - Hide clear button in Text filter * 4002 - Add counter label for multi select * 4002 - Expose Select onMenuClose & onMenuOpen props * 4002 - Add Filter multiselect styling and tooltip * 4002 - Fix table overlapping select options * 4002 - Add spacing between label and search input * 4002 - Fix props order in Select * 4002 - Rename isTooltipVisible to canDisplayTooltip * 4002 - Rename MultiValue to MultiValueSummary * 4002 - Rename multiLabelKey to multiLabelSummaryKey * 4002 - Remove import as OriginalMultiValueProps * 4002 - Render Text x button conditionally * 4002 - Update useTooltipContent * 4002 - Fix styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-10-18.17-40-48.mp4
(After scss updates based on comments:)
