Files with computed name #607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SteRiccio
requested changes
Nov 27, 2024
Comment on lines
+10
to
+11
| const {fileName: fileNameUuid, fileNameCalculated} = | ||
| node?.value?.fileName; |
There was a problem hiding this comment.
this one looks wrong, it should be:
const {fileName: fileNameUuid, fileNameCalculated} =
node?.value ?? {}
| @@ -86,7 +86,7 @@ const NodeValueRender = ({node = false, nodeDef}) => { | |||
| return ( | |||
| <> | |||
| <Container> | |||
| {node?.value ? ( | |||
| {node?.value && node?.value?.fileName ? ( | |||
There was a problem hiding this comment.
it could be simply node?.value?.fileName
There was a problem hiding this comment.
there are also helper methods in arena-core for this, e.g. NodeValues.getFileName
| @@ -59,7 +65,7 @@ const useFile = ({nodeDef, node, isImage = false}) => { | |||
| const deleteFile = useCallback(() => { | |||
| handleDelete({ | |||
| node, | |||
| label: node?.value?.fileName, | |||
| label: node?.value?.fileNameCalculated, | |||
There was a problem hiding this comment.
in this case, if fileNameCalculated is missing it should default to something else
|
also please check the SonarCloud issues |
Base automatically changed from
fix-multiple-entity-home-keys-visibility-599
to
fix-login-button-603
November 28, 2024 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.