Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local storage #13057

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 2, 2025

What? Why?

I was pondering lengthy deploy times while staging a pull request. The longest process is compiling assets. Reviewing our used Javascript libraries I saw angular-local-storage.js but we don't use local storage anymore. So I removed it.

What should we test?

  • No test.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Jan 2, 2025
@mkllnk mkllnk self-assigned this Jan 2, 2025
@mkllnk mkllnk force-pushed the remove-local-storage branch from 858def6 to 0f1f4b2 Compare January 2, 2025 04:30
@mkllnk mkllnk force-pushed the remove-local-storage branch from 0f1f4b2 to 558d4de Compare January 2, 2025 04:42
@mkllnk mkllnk marked this pull request as ready for review January 2, 2025 05:10
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dacook dacook merged commit a89d65c into openfoodfoundation:master Jan 6, 2025
51 checks passed
@mkllnk mkllnk deleted the remove-local-storage branch January 6, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants