DFC Orders: Calculate wholesale price for imported retail variants #13033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
added
the
user facing changes
|
Variant pricing looks good for me. 👍🏻 |
dacook
approved these changes
Dec 16, 2024
|
|
||
| wholesale_variant_price = transformation.offer.price | ||
|
|
||
| return unless wholesale_variant_price |
There was a problem hiding this comment.
unless price is present? a number? positive?
I guess for all intents and purposes it doesn't matter, if it's truthy, we can assume in this context that it's valid? I'm not familiar with the price data structure so I can only assume.
But if we're going to do a division on it later, it might we worth checking it a bit more thoroughly.
There was a problem hiding this comment.
Yes, I was aware of that assumption. Thanks for checking though. It's either a number or nil.
|
Reviews and testing done, ready to merge! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders
What? Why?
In OFN, enterprises add fees on top of producer prices to cover their expenses. But when a DFC product is imported with its recommended retail price then the resulting price in the OFN shop is too high. In the current implementation, retail variants are not ordered in individually, they are ordered as bulk items with a cheaper wholesale price. Considering this backordering logic, we need to set the price of an imported retail variant to the wholesale cost price, calculated from the wholesale variant.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates