Remove unused renderSvg, ofnDisableScroll, integer, ofnScrollTo angular directives #12979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
approved these changes
Nov 18, 2024
Comment on lines
-37
to
-40
| svg { | ||
| path { | ||
| fill: $disabled-dark; | ||
| } |
There was a problem hiding this comment.
Although this rule isn't scoped to render-svg, it probably was intended to be. It looks to me like there's never an svg in this context:
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/views/shops/_fat.html.haml#L13-L14
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/views/producers/_fat.html.haml#L25-L26
mkllnk
approved these changes
Nov 21, 2024
mkllnk
added
the
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This partially addresses #9477 and removes four unused angular directives.
renderSvgdirective was introduced in bc93ce5 and seems to have been removed in Remove taxon icons #5713ofnDisableScrolldirective was introduced in 22aaa24 and seems to have been removed in 59c13b9integerdirective was introduced in 0895bd8 and seems to have been removed in 01c4882ofnScrollTodirective was introduced in de369d9 and seems to have been removed in 427f535What should we test?
Confirm the directives aren't called anywhere e.g.
And on staging:
Release notes