Ensure shipment gets updated when an order is updated

[rioug]

What? Why?

I came across this while looking at #12907
Given an order up to "Order Summary" step, if a customer then update the cart by going back to the shop page via the link next to the cart, the order shipment won't be updated.
It results in :

• the data on the order detail page in the back office being wrong
• the stock level not being updated properly

To fix this, we make sure we delete existing shipment and restart the checkout flow.

Order confirmation started with 2 potatoes test , was updated to 4 potatoes test and 3 potatoes

Admin screen showing only the original items/quantity , 2 potatoes test

Potatoes test stock reduced from 50 to 48, and Potatoes stock stayed at 20

What should we test?

As an enterprise manager:

• set up a product with some stock, ie not "on demand"

As a customer

1. update quantity

• Start an order (use a product with stock) , proceed to checkout and progress to "Order confirmation" step
• Click on the shop link next to the cart
• update an item quantity of a product with stock
• Proceed to checkout again
  --> the order should have the correct items and quantity
• Complete the order

2. add a new item

• Start an order , proceed to checkout and progress to "Order confirmation" step
• Click on the shop link next to the cart
• add a new item in the cart, with a product with a stock
• Proceed to checkout again
  --> the order should have the correct items and quantity
• Complete the order

For both scenario, As an enterprise manager

• open the order just created
  --> The items should all be there and have the correct quantity
• Go to the Bulk Edit product page
  --> verify that the stock of the products in the order have been decreased by the correct number

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

[dacook]

Nice followup!

I wonder if we can do it more efficiently? And I'm unsure about the spec.

[dacook]

Looks like this tests creating mode, but not updating an existing line item (Which I think is what it should be testing)

[rioug]

I updated the specs to test both in creating and updating scenario

[filipefurtad0]

Hi @rioug,

Nice catch! Thanks for your detailed steps on how to reproduce and test this PR.

Before:

• after i) starting an order (use a product with stock), ii) proceeding to checkout and progress to "Order confirmation" step and iii) click on the shop link next to the cart to update the order and iv) continuing checkout it was observed that:
  • redirection occurred to the /summary step
  • the order on the customer view was displayed correctly
  • but not on the stock of the items (backoffice view): it was not decreased by the correct amount

• nor on the order edit page (backoffice view)

After this PR, and repeating the step, it was possible to observe that:

• redirection occurred to the /details step
• the order on the customer view was displayed correctly
• the stock of the items (backoffice view) was decreased by the correct amount

• the order edit page (backoffice view) displayed the correct line items and amounts

Looks great! Merging.