-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stimulus reflex #12946
Closed
wandji20
wants to merge
25
commits into
openfoodfoundation:master
from
wandji20:remove-stimulus-reflex
Closed
Remove stimulus reflex #12946
wandji20
wants to merge
25
commits into
openfoodfoundation:master
from
wandji20:remove-stimulus-reflex
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wandji20
force-pushed
the
remove-stimulus-reflex
branch
2 times, most recently
from
October 24, 2024 14:15
130aae7
to
601cf7f
Compare
…ert to resend email confirmation with turbo_stream
…ns with turbo_stream
wandji20
force-pushed
the
remove-stimulus-reflex
branch
from
October 24, 2024 14:25
601cf7f
to
e9296e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This is a continuation of PR, which completely moves cable-ready and stimulus reflex-related logic to be handled with turbo streams.
What should we test?
The overall functionality of the app should be maintained without any errors.
Release notes
Migrate Cable ready and stimulus reflex to turbo streams
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
N?A
Documentation updates
N/A