Sanitise HTML attributes in the database #12943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to run the sanitiser each time we read an attribute. It's a waste of time.
mkllnk
added
the
technical changes only
dacook
approved these changes
Oct 28, 2024
| # We prefer to keep migrations isolated and not affected by changing | ||
| # application code in the future. | ||
| # If we need to change the sanitizer in the future we may need a new | ||
| # migration (not change the old one) to sanitise the data properly. |
|
Hey @mkllnk , Changed the mentioned attributes, before staging the PR and verified them after staging, under the following URLs:
Spotted nothing unusual, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Please use project Discover Regenerative (Macdoch pt 2): #3A. Tech - OFN & OFN/DFC Endpoints to track work on this issue.
What? Why?
We introduced HTML sanitisation on attribute assignment before but there was still dirty data in the database. This pull request sanitises the database. That allows us to remove the sanitisation every time we read one of the HTML attributes.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates