-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Dockerv2 #12875
Use Dockerv2 #12875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
docker-compose.exe down -v --remove-orphans | ||
docker compose down -v --remove-orphans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if the .exe
is not needed any more ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm not sure. It should have never been necessary. I can't get the server to respond in pure Windows using docker-compose.exe
or docker compose
The containers spin up with either of them, but I don't get a response from the server. I was hoping someone who uses it could provide some feedback.
I develop with Ubuntu and WSL Ubuntu. I tested the docker setup with both and it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you asked for feedback 👍 I think it's a minor use case so we should be good to merge as it is. If some run into any issue we can revisit. I'll wait a few more days for feedback before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It is easy enough to revert if something comes up, so it should be relatively safe.
b0fd4fc
to
21b7e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I hope that this will work for more people now.
What? Why?
Dockerv1 used
docker-compose
executable (with a dash). Dockerv2 usesdocker compose
(with a space). Thedocker-compose
executable is no longer receiving updates. With some recent versions of Docker, this may cause aContainerError
when trying to run it.What should we test?
Spin up the docker container:
Verify that there are no fatal errors.
Visit HTTP://localhost:3000/
This has been tested under Ubuntu, but not on Windows/Mac
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates
Getting Started Guide was updated to include the
docker compose
command and remove the requirement of installing Dockerv1.