Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dockerv2 #12875

Merged

Conversation

macanudo527
Copy link
Collaborator

What? Why?

Dockerv1 used docker-compose executable (with a dash). Dockerv2 uses docker compose (with a space). The docker-compose executable is no longer receiving updates. With some recent versions of Docker, this may cause a ContainerError when trying to run it.

What should we test?

Spin up the docker container:

docker/server

Verify that there are no fatal errors.
Visit HTTP://localhost:3000/

This has been tested under Ubuntu, but not on Windows/Mac

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Getting Started Guide was updated to include the docker compose command and remove the requirement of installing Dockerv1.

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docker-compose.exe down -v --remove-orphans
docker compose down -v --remove-orphans
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if the .exe is not needed any more ?

Copy link
Collaborator Author

@macanudo527 macanudo527 Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure. It should have never been necessary. I can't get the server to respond in pure Windows using docker-compose.exe or docker compose The containers spin up with either of them, but I don't get a response from the server. I was hoping someone who uses it could provide some feedback.

I develop with Ubuntu and WSL Ubuntu. I tested the docker setup with both and it works fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you asked for feedback 👍 I think it's a minor use case so we should be good to merge as it is. If some run into any issue we can revisit. I'll wait a few more days for feedback before merging.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It is easy enough to revert if something comes up, so it should be relatively safe.

@macanudo527 macanudo527 force-pushed the docker/upgrade_to_dockerv2 branch from b0fd4fc to 21b7e6e Compare September 26, 2024 00:21
@rioug rioug added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Sep 30, 2024
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I hope that this will work for more people now.

@mkllnk mkllnk merged commit 3c613f8 into openfoodfoundation:master Oct 1, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants