Skip to content

Commit

Permalink
Merge pull request #12969 from chahmedejaz/task/12919-remove-empty-op…
Browse files Browse the repository at this point in the history
…tion-from-unit-scale-dropdown

[Products] Empty option on unit scale dropdown
  • Loading branch information
filipefurtad0 authored Nov 28, 2024
2 parents d90c4f6 + bafb881 commit 58d174f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/views/admin/products_v3/_variant_row.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
= f.hidden_field :variant_unit_scale
= f.select :variant_unit_with_scale,
options_for_select(WeightsAndMeasures.variant_unit_options, variant.variant_unit_with_scale),
{ include_blank: true },
{ include_blank: t('.select_unit_scale') },
{ class: "fullwidth no-input", 'aria-label': t('admin.products_page.columns.unit_scale'), data: { "controller": "tom-select", "tom-select-options-value": '{ "plugins": [] }', action: "change->toggle-control#displayIfMatch" }, required: true }
= error_message_on variant, :variant_unit, 'data-toggle-control-target': 'control'
.field
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,7 @@ en:
category_field_name: "Category"
tax_category_field_name: "Tax Category"
producer_field_name: "Producer"
select_unit_scale: Select unit scale
clone:
success: Successfully cloned the product
error: Unable to clone the product
Expand Down

0 comments on commit 58d174f

Please sign in to comment.