Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip installing ruby, the app does it #979

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Jan 7, 2025

Now we don't have to manage the ruby version in two places. The bash script in the app is also faster than Ansible. Follow up from:

@mkllnk mkllnk self-assigned this Jan 7, 2025
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@mkllnk mkllnk force-pushed the we-dont-manage-rbenv branch from a8205ec to ac53be3 Compare January 8, 2025 02:54
Now we don't have to manage the ruby version in two places. The bash
script in the app is also faster than Ansible.
@mkllnk mkllnk force-pushed the we-dont-manage-rbenv branch from ac53be3 to ce913be Compare January 8, 2025 03:16
Copy link
Contributor

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👍

@mkllnk mkllnk merged commit d94e7e5 into openfoodfoundation:master Jan 8, 2025
2 checks passed
@mkllnk mkllnk deleted the we-dont-manage-rbenv branch January 8, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants