-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart after config changes #911
Merged
mkllnk
merged 3 commits into
openfoodfoundation:master
from
dacook:restart-with-config-changes
Apr 23, 2024
Merged
Restart after config changes #911
mkllnk
merged 3 commits into
openfoodfoundation:master
from
dacook:restart-with-config-changes
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dacook
force-pushed
the
restart-with-config-changes
branch
2 times, most recently
from
December 6, 2023 01:16
7d028f7
to
9da8e66
Compare
I accidentally just "tested" this on us_prod. Thankfully, it works 😌 ✅
|
dacook
force-pushed
the
restart-with-config-changes
branch
from
April 22, 2024 02:20
9da8e66
to
f5fcd99
Compare
I'm not sure why it fails otherwise.
rioug
reviewed
Apr 23, 2024
rioug
approved these changes
Apr 23, 2024
mkllnk
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure relevant services are restarted, after updating Rails or Postgres environment variables. Normally they would be restarted when the full provision playbook is executed anyway, but my vision is to be able to perform individual actions quicker.
My vision: to update app config in a minute with
--tags=app
, instead of waiting ages for every single action to run.Probably this could have been separated into two separate tasks (one for Rails and one for Postgres). But it didn't seem worth spending more time on. Especially because additional tasks make ansible even slower...
I'm not sure why it failed on CI.
Update: I thought it was time to act on this one, so found a way to avoid the sidekiq error. Hmm, perhaps it was never started on initial setup? Then we should probably fix that.. but is this ok for now?