Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Harmonization between modal sheets #5875

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 18, 2024

Hi everyone!

The "old" modal sheets were not aligned with the colors of the Product page.

  • Orange indicator added
    1

  • In dark mode, when the first item was selected, it had the same color as the header
    2

  • The same for the image source (you can notice a small shadow between the header and the content)
    3

  • User lists: color harmonization + a brighter button
    4

  • Users lists in dark mode: color harmonization
    5

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 6.83%. Comparing base (4d9c7fc) to head (a35cec9).
Report is 481 commits behind head on develop.

Files with missing lines Patch % Lines
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 24 Missing ⚠️
...ib/pages/preferences/user_preferences_widgets.dart 0.00% 7 Missing ⚠️
...s/smooth_app/lib/pages/all_product_list_modal.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5875      +/-   ##
==========================================
- Coverage     9.54%   6.83%   -2.72%     
==========================================
  Files          325     428     +103     
  Lines        16411   23593    +7182     
==========================================
+ Hits          1567    1613      +46     
- Misses       14844   21980    +7136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

2 participants