-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Photo gallery with tabs #5872
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This is a very nice usability improvement for contributors
- I'd be tempted to have a secret gesture (Long press on the outdated image) or button to directly jump to the camera to refresh the current photo
- We will probably have to tweak this widget to have an inline equivalent to the tab system (drop-down, little list of available languages, accordion of available languages) when we insert it into the photos tab. By then anyway, the language shown in the photos tab will be probably good for 99% of viewers.
For this one, I first need to change the product addition flow.
An alternative would be to show a different layout on the product page, with only the "best pictures". |
@teolemon I have a doubt about my implementation. Is it what we want? Or should I open the tab containing the user language? |
If and only if it has photos already. Otherwise, it's just a tap away to add photos. |
Ok, so I let this PR as is |
Hi everyone!
Here's the final touch for the photo gallery.
🎥 Video: https://github.com/user-attachments/assets/8308da52-1577-492d-afe6-4d1e35f48e20
There are now tabs for languages on top of the screen:
And the action button is not a FAB anymore, but a footer button: