Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Product page: add to list counter + appbar shadow #5869

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 16, 2024

Hi everyone!

I know, I know, this PR is only details…
But there's now a shadow below the AppBar when scrolling:

IMG_65A7987FAD24-1

In the action bar, the icon next to "Add to a list" will show the number of lists:
IMG_1364

When the Compare feature is disabled (incomplete product), the icon is crossed out:
IMG_1370

A demo of the first two changes:
https://github.com/user-attachments/assets/b33115ee-2aa9-47e6-bc7a-1705b34b78f5

Note: I don't know why, but the file packages/smooth_app/lib/pages/product/product_page/new_product_footer.dart was not removed (fixed now ✅)

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 2.98507% with 65 lines in your changes missing coverage. Please review.

Project coverage is 6.83%. Comparing base (4d9c7fc) to head (ed26c4f).
Report is 481 commits behind head on develop.

Files with missing lines Patch % Lines
...t_page/footer/new_product_footer_add_to_lists.dart 0.00% 21 Missing ⚠️
packages/smooth_app/lib/resources/app_icons.dart 11.11% 16 Missing ⚠️
...roduct/product_page/footer/new_product_footer.dart 0.00% 14 Missing ⚠️
...pages/product/product_page/new_product_header.dart 0.00% 11 Missing ⚠️
...oth_app/lib/pages/product/product_list_helper.dart 0.00% 2 Missing ⚠️
...oduct_page/footer/new_product_footer_settings.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5869      +/-   ##
==========================================
- Coverage     9.54%   6.83%   -2.72%     
==========================================
  Files          325     428     +103     
  Lines        16411   23629    +7218     
==========================================
+ Hits          1567    1614      +47     
- Misses       14844   22015    +7171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good to me. The list counter is a nice touch, but we'll probably need a more visible option at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants