-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Scan cards share the same UI #5866
Open
g123k
wants to merge
2
commits into
openfoodfacts:develop
Choose a base branch
from
g123k:scan_cards_revamp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🥫 Product page
🤗 Onboarding
We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
summary card
✏️ Editing
Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
ranking
labels
Nov 16, 2024
github-actions
bot
added
🤳🥫 Scan
We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
product scan carousel
router
labels
Nov 16, 2024
teolemon
reviewed
Nov 16, 2024
Co-authored-by: Pierre Slamich <[email protected]>
teolemon
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @g123k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✏️ Editing
Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
🤗 Onboarding
We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
🥫 Product page
product scan carousel
ranking
router
🤳🥫 Scan
We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
summary card
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
This is a big PR with changes to 39 files (new code + renaming).
⚠️ I haven't translated anything into English. It would be nice if you could do it.
🎥 Video: https://youtu.be/K1lqRVUxayo
What's new
Side quests:
The Hero animation works between the carousel / product page / gallery / details (cf video)
From the carousel, the product page shows a minimize button:
The Compare button on the scanner uses the correct icon:
Product found
The obsolete icon is visible from the carousel. Is-it useful (cc @teolemon?)
Loading
The animation is still used:
New product
Error (network)
Error (invalid barcode)
List of changes:
product_title_card.dart
: Pass the heroTag to the picture + use the same layout for all cards (except in the onboarding, where the image is hidden)smooth_product_base_card.dart
: The base card for all scan cards + shared Widgetssmooth_card.dart
: TheContainer
is replaced by aPadding
(faster)product_compatibility_helper.dart
: Help to format the score with at least 2 digitsstrings_helper.dart
: Code movedapp_navigator.dart
: Provide the back button type for the product pagereinvention_page.dart
: Nothing relevant -OnboardingText
is moved elsewhereedit_product_page.dart
: A generic barcode Widget is now availableproduct_compatibility_header.dart
: Not used anymoreproduct_image_viewer.dart
: A fix for multiple Heroes animations