-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Polish brands, stores and labels #1184
base: main
Are you sure you want to change the base?
Conversation
data/ocr/brand_logo_annotation.txt
Outdated
@@ -257,6 +257,7 @@ toupargel||Toupargel | |||
tropicana orange juice||Tropicana | |||
tropicana||Tropicana | |||
Tropicana||Tropicana | |||
TYMBARK||Tymbark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not obvious, but this file is used to match IDs return by Google Cloud Vision to Open Food Fact IDs. Is TYMBARK an ID returned by Google Cloud Vision?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that wasn't obvious to me, I thought it's supposed to be the way it's written on the packaging.
In that case I shouldn't add those without knowledge about Google Cloud Vision, is that right?
data/ocr/label_flashtext.txt
Outdated
@@ -114,6 +115,7 @@ en:sustainable-palm-oil||sustainable palm oil | |||
en:sustainable-seafood-msc||www.msc.org | |||
en:sustainable-seafood-msc||pêche durable msc | |||
en:utz-certified||utz certified | |||
en:vegan||suitable for vegans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As vegan is already there you can just add "vegans" as a pattern.
data/ocr/store_regex.txt
Outdated
@@ -1,22 +1,49 @@ | |||
7-eleven | |||
Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum it will introduce many false positive, it's quite a common word.
data/ocr/store_regex.txt
Outdated
AhorraMás | ||
AhorraMás||ahorramas | ||
Albertsons | ||
Albert Heijn | ||
Alcampo | ||
Aldi | ||
Aldi||asia green garden | ||
Aldi||balta mare | ||
Aldi||biscotto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing about false positive maybe.
Co-authored-by: Pierre Slamich <[email protected]>
@raphael0202 I removed Netto from
|
84b766d
to
f55eaaf
Compare
Stores are applied automatically, that's the issue... I'm not super fan of this store system we put in place, I would much rather deduce the store from the brand in Robotoff (see #1225). |
What