-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add various fixes and improvements #1007
Conversation
raphael0202
commented
Dec 2, 2022
•
edited
Loading
edited
- fix: update barcode range check during insight import
- fix: fix default value for MONGO_URI in .env
- fix: fix mongoDB healthcheck
- fix: add lower value for MongoDB serverSelectionTimeoutMS 30s is too high
- fix: add mongodb service in webnet network
- fix: don't build robotoff image by default
- docs: fix error in dev-install.md
- feat: remove update_recycle task
This task has never been used
Otherwise other services cannot access it
30s is too high
catch ServerSelectionTimeoutError errors
4ef7a6d
to
e3ededa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 53.06% 55.44% +2.37%
==========================================
Files 93 79 -14
Lines 7076 6520 -556
==========================================
- Hits 3755 3615 -140
+ Misses 3321 2905 -416
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -58,7 +58,7 @@ INFLUXDB_AUTH_TOKEN= | |||
# INFLUXDB_HOST=host.docker.internal | |||
|
|||
# MongoDB (dev setting, using product opener network) | |||
MONGO_URI=mongodb://mongodb.po_default:27017 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep that as a comment for those who have a local product opener instance ?
PO install on the side is not the most common one
Don't check barcode range for insights generated from logos (universal-logo-detector model) that were annotated manually
7f7b1c7
to
926e538
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |