Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add various fixes and improvements #1007

Merged
merged 8 commits into from
Dec 6, 2022
Merged

fix: add various fixes and improvements #1007

merged 8 commits into from
Dec 6, 2022

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Dec 2, 2022

  • fix: update barcode range check during insight import
  • fix: fix default value for MONGO_URI in .env
  • fix: fix mongoDB healthcheck
  • fix: add lower value for MongoDB serverSelectionTimeoutMS 30s is too high
  • fix: add mongodb service in webnet network
  • fix: don't build robotoff image by default
  • docs: fix error in dev-install.md
  • feat: remove update_recycle task

@raphael0202 raphael0202 marked this pull request as ready for review December 2, 2022 17:51
@raphael0202 raphael0202 requested a review from a team as a code owner December 2, 2022 17:51
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1007 (7f7b1c7) into master (3a5f9ab) will increase coverage by 2.37%.
The diff coverage is 61.14%.

❗ Current head 7f7b1c7 differs from pull request most recent head 926e538. Consider uploading reports for the commit 926e538 to get more accurate results

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   53.06%   55.44%   +2.37%     
==========================================
  Files          93       79      -14     
  Lines        7076     6520     -556     
==========================================
- Hits         3755     3615     -140     
+ Misses       3321     2905     -416     
Impacted Files Coverage Δ
robotoff/cli/insights.py 0.00% <0.00%> (ø)
robotoff/elasticsearch/export.py 84.84% <ø> (-12.38%) ⬇️
robotoff/health.py 0.00% <0.00%> (ø)
robotoff/insights/extraction.py 48.33% <0.00%> (-0.82%) ⬇️
robotoff/insights/normalize.py 100.00% <ø> (ø)
robotoff/mongo.py 83.33% <0.00%> (ø)
...tion/object_detection/utils/visualization_utils.py 19.20% <0.00%> (ø)
robotoff/prediction/ocr/category.py 96.55% <ø> (ø)
robotoff/prediction/ocr/core.py 31.85% <ø> (-0.60%) ⬇️
robotoff/prediction/ocr/image_flag.py 41.02% <ø> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile Show resolved Hide resolved
docker/mongodb.yml Show resolved Hide resolved
@@ -58,7 +58,7 @@ INFLUXDB_AUTH_TOKEN=
# INFLUXDB_HOST=host.docker.internal

# MongoDB (dev setting, using product opener network)
MONGO_URI=mongodb://mongodb.po_default:27017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep that as a comment for those who have a local product opener instance ?

PO install on the side is not the most common one
Don't check barcode range for insights generated from logos
(universal-logo-detector model) that were annotated manually
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 143 Code Smells

0.0% 0.0% Coverage
0.3% 0.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants