feat:Quick categories #93
Conversation
Change version
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $("ul[id^='products_'].search_results li[data-code]").each(function(index, element) { | ||
| let code = $(this).attr('data-code'); | ||
|
|
||
| $('<div id="quick_category_' + code + '" class="list_categories_card"></div>').insertBefore( $('a.list_product_a', this) ); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
| function showListHungerGamesButtons(){ | ||
| $("ul[id^='products_'].search_results li[data-code]").each(function(index, element) { | ||
| let barcode = $(this).attr('data-code'); | ||
| $(this).append('<a class="list_hunger_games_logo_search" alt="Hunger games logo search" title="Hunger games logo search" href="https://hunger.openfoodfacts.org/logos/search?barcode='+barcode+'"><span class="material-icons" id="list_button">image_search</span></a>'); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
There was a problem hiding this comment.
@DanieliusAsm sorry to review this so late. You have added a bunch of code, so I needed to take time to review it. In fact, some of the code, such as function getFrontImagesToRotate, were just moved to another place.
Also you are doing two different things in this PR: you're fixing a bug, and you're adding a feature. Both are interesting, but it's more difficult to review. And "quick categories" does not seem to work on my side :(
It would be better to have separate PR for the bug and for the feature, could you do this?
What
Screenshot
Fixes bug(s)
Part of