Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send events when editing products #7303

Merged
merged 10 commits into from
Sep 9, 2022
Merged

feat: send events when editing products #7303

merged 10 commits into from
Sep 9, 2022

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet
Copy link
Contributor Author

Currently not working in a dev environment, as the EVENTS_URL environment variable seems not passed down, even after a make dev. Probably a bug somewhere.

www-data@d7be0fbd4116:/opt/product-opener/lib/ProductOpener$ env | grep EVEN
EVENTS_URL=https://events.openfoodfacts.org

[6242] /opt/product-opener/lib/ProductOpener/Events.pm 101 ProductOpener.Events {action => 'process',events_url => undef,request => 'lYrg7I3BWPFipE38',type => 'edit'} send_event EVENTS_URL not defined

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 7, 2022
@stephanegigandet stephanegigandet changed the title feat: send events when editing products (wip) feat: send events when editing products Sep 7, 2022
@stephanegigandet
Copy link
Contributor Author

This is now ready for review.

There is a slight discrepancy as the events api except an integer for the barcode, while we use strings in product opener: openfoodfacts/openfoodfacts-events#137

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 7, 2022
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a log level to change.

cgi/product_multilingual.pl Outdated Show resolved Hide resolved
lib/ProductOpener/Events.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Events.pm Show resolved Hide resolved
lib/ProductOpener/Events.pm Outdated Show resolved Hide resolved
@teolemon
Copy link
Member

teolemon commented Sep 7, 2022

FYI @ocervell :-)

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !

@alexgarel alexgarel merged commit 8ef9eea into main Sep 9, 2022
@alexgarel alexgarel deleted the events branch September 9, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants