-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send events when editing products #7303
Conversation
Currently not working in a dev environment, as the EVENTS_URL environment variable seems not passed down, even after a make dev. Probably a bug somewhere. www-data@d7be0fbd4116:/opt/product-opener/lib/ProductOpener$ env | grep EVEN [6242] /opt/product-opener/lib/ProductOpener/Events.pm 101 ProductOpener.Events {action => 'process',events_url => undef,request => 'lYrg7I3BWPFipE38',type => 'edit'} send_event EVENTS_URL not defined |
This is now ready for review. There is a slight discrepancy as the events api except an integer for the barcode, while we use strings in product opener: openfoodfacts/openfoodfacts-events#137 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but a log level to change.
FYI @ocervell :-) |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool !
Some code to send events to https://github.com/openfoodfacts/openfoodfacts-events : #6259