This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 159
feat: Finish the new product page revamp based on the Attributes API - Implementation of product attributes - Pr/#707 #780
Closed
jncosideout
wants to merge
25
commits into
openfoodfacts:develop
from
jncosideout:pr/#707-Organic-label-mockup
Closed
Commits on May 1, 2021
-
Create UI for ProductAttributes in Detail View
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: openfoodfacts#707
Configuration menu - View commit details
-
Copy full SHA for e758700 - Browse repository at this point
Copy the full SHA e758700View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4efdf9 - Browse repository at this point
Copy the full SHA c4efdf9View commit details -
Attempt to show floatingPanel from closure
This snapshot is not workable, I just want to preserve an idea which probably won't work, which is passing a closure to AttributeTableViewCell to launch the floatingPanel. However, I made FormTableViewController the owner of the floating panel and that is not allowed. So now I am switching to a new strategy to make a delegate for AttributeTableViewCell and designate the ProductDetailTableViewController as the delegate and as the floating panel host as I originally intended.
Configuration menu - View commit details
-
Copy full SHA for 2f8f9eb - Browse repository at this point
Copy the full SHA 2f8f9ebView commit details -
Create custom VC for ProdAttr. and use delegation
Created delegate protocol for AttributeTableViewCell to call back to ProductDetailViewController so it can launch the FloatingPanelVC Extend ProductDetailVC so it can handle FloatingPanels similar to ScannerViewController. Create ProductAttributeViewController.swift and .storyboard to be the FloatingPanels VC and view to hold AttributeView Resolves: openfoodfacts#707
Configuration menu - View commit details
-
Copy full SHA for f49d47f - Browse repository at this point
Copy the full SHA f49d47fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 788eeb1 - Browse repository at this point
Copy the full SHA 788eeb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6c4ee2 - Browse repository at this point
Copy the full SHA d6c4ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c52e88 - Browse repository at this point
Copy the full SHA 9c52e88View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3dbd1 - Browse repository at this point
Copy the full SHA ef3dbd1View commit details -
NOT READY FOR PROD. Wrap text around the image
Add the frame of the image to the exclusion path of the text view. Create func getIconAspectConstraint() to get the dynamic aspect ratio of the image in code so we can dynamically adjust the imageView height and width. Place image related code in completion handle of KingFisher setImage(with: resource) to ensure the adjustments are attempted after the image is retrieved. Resolves: openfoodfacts#707
Configuration menu - View commit details
-
Copy full SHA for ca7a673 - Browse repository at this point
Copy the full SHA ca7a673View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd472c6 - Browse repository at this point
Copy the full SHA bd472c6View commit details
Commits on May 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a5ad31 - Browse repository at this point
Copy the full SHA 8a5ad31View commit details
Commits on May 5, 2021
-
Switch ImageView to UIWebView, add code to scale SVGs, regex search i…
…n SVG's HTML to get dimensions
Configuration menu - View commit details
-
Copy full SHA for 28b335e - Browse repository at this point
Copy the full SHA 28b335eView commit details
Commits on May 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1a89da1 - Browse repository at this point
Copy the full SHA 1a89da1View commit details
Commits on May 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 04b4ca1 - Browse repository at this point
Copy the full SHA 04b4ca1View commit details
Commits on May 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5a3bcba - Browse repository at this point
Copy the full SHA 5a3bcbaView commit details
Commits on May 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4c9a315 - Browse repository at this point
Copy the full SHA 4c9a315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2839448 - Browse repository at this point
Copy the full SHA 2839448View commit details
Commits on May 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6ea4111 - Browse repository at this point
Copy the full SHA 6ea4111View commit details
Commits on Jun 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 42ae84a - Browse repository at this point
Copy the full SHA 42ae84aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 246deec - Browse repository at this point
Copy the full SHA 246deecView commit details
Commits on Aug 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e3f2d7a - Browse repository at this point
Copy the full SHA e3f2d7aView commit details
Commits on Sep 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 69a4619 - Browse repository at this point
Copy the full SHA 69a4619View commit details
Commits on Oct 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ec2c7f0 - Browse repository at this point
Copy the full SHA ec2c7f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69f0ad5 - Browse repository at this point
Copy the full SHA 69f0ad5View commit details
Commits on Oct 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 561fea1 - Browse repository at this point
Copy the full SHA 561fea1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.