Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat: Finish the new product page revamp based on the Attributes API - Implementation of product attributes - Pr/#707 #780

Commits on May 1, 2021

  1. Create UI for ProductAttributes in Detail View

    The product summary Overview needs to display rows for a product's
    Attributes, whose data are fetched from the newly integrated
    ProductAttribute API endpoint. This required a subclass of UIView and a
    new class of TableView Cells to hold them. When the user taps an
    Attribute row, a pop-up info card will be displayed showing a longer
    description. Swiping left will show more related information on the
    pop-up info card.
    
    Resolves: openfoodfacts#707
    jncosideout committed May 1, 2021
    Configuration menu
    Copy the full SHA
    e758700 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4efdf9 View commit details
    Browse the repository at this point in the history
  3. Attempt to show floatingPanel from closure

    This snapshot is not workable, I just want to preserve an idea which
    probably won't work, which is passing a closure to
    AttributeTableViewCell to launch the floatingPanel. However, I made
    FormTableViewController the owner of the floating panel and that is not
    allowed. So now I am switching to a new strategy to make a delegate for
    AttributeTableViewCell and designate the
    ProductDetailTableViewController as the delegate and as the floating
    panel host as I originally intended.
    jncosideout committed May 1, 2021
    Configuration menu
    Copy the full SHA
    2f8f9eb View commit details
    Browse the repository at this point in the history
  4. Create custom VC for ProdAttr. and use delegation

    Created delegate protocol for AttributeTableViewCell to call back to
    ProductDetailViewController so it can launch the FloatingPanelVC
    Extend ProductDetailVC so it can handle FloatingPanels similar to
    ScannerViewController. Create ProductAttributeViewController.swift and
    .storyboard to be the FloatingPanels VC and view to hold AttributeView
    
    Resolves: openfoodfacts#707
    jncosideout committed May 1, 2021
    Configuration menu
    Copy the full SHA
    f49d47f View commit details
    Browse the repository at this point in the history
  5. Display floating panel

    jncosideout committed May 1, 2021
    Configuration menu
    Copy the full SHA
    788eeb1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d6c4ee2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9c52e88 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ef3dbd1 View commit details
    Browse the repository at this point in the history
  9. NOT READY FOR PROD. Wrap text around the image

    Add the frame of the image to the exclusion path of the text view.
    Create func getIconAspectConstraint() to get the dynamic aspect ratio of
    the image in code so we can dynamically adjust the imageView height and
    width. Place image related code in completion handle of KingFisher
    setImage(with: resource) to ensure the adjustments are attempted after
    the image is retrieved.
    
    Resolves: openfoodfacts#707
    jncosideout committed May 1, 2021
    Configuration menu
    Copy the full SHA
    ca7a673 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bd472c6 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Configuration menu
    Copy the full SHA
    8a5ad31 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Switch ImageView to UIWebView, add code to scale SVGs, regex search i…

    …n SVG's HTML to get dimensions
    jncosideout committed May 5, 2021
    Configuration menu
    Copy the full SHA
    28b335e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Configuration menu
    Copy the full SHA
    1a89da1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Configuration menu
    Copy the full SHA
    04b4ca1 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Configuration menu
    Copy the full SHA
    5a3bcba View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Configuration menu
    Copy the full SHA
    4c9a315 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2839448 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Configuration menu
    Copy the full SHA
    6ea4111 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Update ios-release.yml

    teolemon authored Jun 12, 2021
    Configuration menu
    Copy the full SHA
    42ae84a View commit details
    Browse the repository at this point in the history
  2. Update ios-release.yml

    teolemon authored Jun 12, 2021
    Configuration menu
    Copy the full SHA
    246deec View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. Configuration menu
    Copy the full SHA
    e3f2d7a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    69a4619 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. Configuration menu
    Copy the full SHA
    ec2c7f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69f0ad5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Configuration menu
    Copy the full SHA
    561fea1 View commit details
    Browse the repository at this point in the history