Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #137 (The barcode field should be a string, not an integer) #210

Closed
wants to merge 3 commits into from

Conversation

jaivardhan-bhola
Copy link

@jaivardhan-bhola jaivardhan-bhola commented Feb 2, 2023

What

Fixed issue where barcode should be string
I am new to all this so if there is an issue please let me know

Resolves

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jaivardhan-bhola jaivardhan-bhola changed the title Fixed issue #137 fix: #137 Feb 2, 2023
@alexgarel
Copy link
Member

Hi @jaivardhan-bhola thank you for contributing.
The problem is that we will have to handle migration, we could use https://sqlalchemy-migrate.readthedocs.io/en/latest/ but maybe it's overkill right now, but do you want to try to give the SQL line I should run to migrate the database ?

@alexgarel
Copy link
Member

@jaivardhan-bhola
Copy link
Author

We'll use

alembic revision -m "Message"
alembic upgrade head

@teolemon teolemon changed the title fix: #137 fix: #137 (The barcode field should be a string, not an integer) Apr 21, 2023
@alexgarel
Copy link
Member

@jaivardhan-bhola thank you for your PR, though I'm closing it as @florentleveque is more advanced on tackling it on #244

@alexgarel alexgarel closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants